Tuya - Air Condioner support - PR9 by Terdious · Pull Request #2458 · GladysAssistant/Gladys

Terdious · 2026-02-23T01:59:04Z

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

If your changes affect the code, did you write the tests?
Are tests passing? (npm test on both front/server)
Is the linter passing? (npm run eslint on both front/server)
Did you run prettier? (npm run prettier on both front/server)
If you are adding a new feature/service, did you run the integration comparator? (npm run compare-translations on front)
Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (forum) for testing before merging.
If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Summary

Add support for Tuya air-conditioner devices reported in issue #2479.
Support both local and cloud read/write flows for AC capabilities:
- switch
- temp_set
- temp_current
- mode
- fan_speed_enum
- horizontal
- vertical
Add dedicated AC fixture coverage and align cloud strategy/mapping tests.

Details

Front (prod):
- add dedicated device feature components for AC fan speed and AC swing controls
- integrate AC features into the room device feature rendering flow
- update AC mode component behavior to align with the new mapping support
Translations:
- add/adjust AC labels in English, French, and German
Server (prod):
- add a dedicated air-conditioner Tuya device type
- add explicit cloud mapping for AC capabilities
- add explicit local mapping for AC DPS capabilities
- register AC device type in Tuya mapping index
- extend Tuya device read/write mappings for AC features
- extend constants for AC-related supported feature values
- simplify tuya.cloudStrategy by removing unreachable/dead branches while preserving behavior
Server tests:
- add a full fixture set for air-conditioner-f3goccgfj6qino4c
- add/extend fixture-driven tests for convert/local mapping/poll/setValue
- add missing AC write mapping regression (AIR_CONDITIONING.BINARY)
- add cloud strategy regression coverage for shadow-only supported codes

Why this matters

AC devices expose a broader and different capability model than previously supported Tuya devices.
Explicit cloud/local mappings keep behavior predictable and easier to maintain across device families.
Fixture-driven coverage ensures onboarding remains stable for future Tuya device additions.

Scope

Compared to tuya-pilot-thermostat-support:

Front (prod)
- +147 lines / -45 lines
Translations
- +93 lines / -6 lines
Server (prod)
- +311 lines / -11 lines
Server Tests
- +778 lines / -0 lines
No package changes.
Total
- 27 files changed
- +1329 lines / -62 lines

Summary by CodeRabbit

New Features
- More air‑conditioning controls: fan‑speed, eco, drying, cleaning, aux‑heat, light, sleep, health.
- Local network discovery and polling for Tuya devices.
- GitHub issue workflow to suggest unsupported/partially supported devices.
Improvements
- Richer Tuya device UI: cloud/local mode, IP/protocol controls, device ranking and partial‑support indicators, better connection states.
- Automatic temperature‑unit detection and conversion.
- Expanded translations (EN/DE/FR) and messaging.

…er models - Added support for air conditioning devices with new mappings and DPS configurations. - Introduced local polling for Tuya devices to improve responsiveness. - Enhanced device conversion logic to include additional parameters such as cloud IP and local override. - Updated feature conversion to utilize advanced DPS mappings for air conditioning. - Implemented new models for air conditioning and power meter, including specific feature mappings. - Improved error handling and logging for local polling and device value setting. - Added unit tests for new feature mappings and conversion logic.

…y device conversion logic

…ité du code

…ttre à jour les tests associés

… champ d'erreur dans le payload de l'événement WebSocket

…s et ajouter des tests pour la gestion des appareils locaux

…on Tuya dans les fichiers de langue

…ion Tuya et mettre à jour les traductions

… des appareils Tuya

… local

…tre l'utilisation d'adresses spécifiques

…eurs de port et mise à jour des traductions

…re des liens vers la documentation et les options de connexion

…réation de rapports GitHub pour les appareils Tuya

…l disconnect features - Added new translations for connection status messages in German, English, and French. - Implemented API endpoints to get Tuya connection status and to manually disconnect from the Tuya cloud. - Updated the Tuya service to handle automatic reconnection logic and manual disconnect state. - Enhanced the SetupTab component to reflect connection status and provide a disconnect button. - Added tests for the new functionality, including status retrieval and manual disconnect.

… erreurs de port

- Implemented device ranking and sorting in DiscoverTab for better user experience. - Added loading indicators and improved UI feedback during device scanning. - Refactored local polling logic to update discovered devices with local information. - Introduced utility functions for managing device parameters, including upserting and normalizing values. - Enhanced local scan response handling to merge existing device parameters. - Updated tests to cover new functionality and ensure reliability of device management.

…ls et des tests associés

… débogage pour la gestion des appareils

…age, ajouter des tests pour la reconnexion automatique et la découverte des appareils

… des paramètres dans le code de configuration Tuya

coderabbitai · 2026-02-23T01:59:26Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds comprehensive Tuya integration: local UDP scanning and local device polling, expanded air-conditioning feature mappings and UI components (fan speed, modes), auto-reconnect and manual-disconnect logic, new Tuya service endpoints and manager methods, richer device conversion/mapping, and extensive tests and i18n updates.

Changes

Cohort / File(s)	Summary
Front — AC feature UI `front/src/components/boxs/device-in-room/DeviceRow.jsx`, `front/src/components/boxs/device-in-room/SupportedFeatureTypes.jsx`, `front/src/components/boxs/device-in-room/device-features/AirConditioningFanSpeedDeviceFeature.jsx`, `front/src/components/boxs/device-in-room/device-features/AirConditioningModeDeviceFeature.jsx`, `front/src/components/boxs/device-in-room/device-features/style.css`, `front/src/utils/consts.js`	Adds fan-speed component, refactors AC mode UI, expands supported AIR_CONDITIONING feature types (FAN_SPEED, ECO, DRYING, CLEANING, AUX_HEAT, LIGHT, SLEEP, HEALTH), and updates icons/styles.
Front — Tuya UI & discovery `front/src/routes/integration/all/tuya/TuyaDeviceBox.jsx`, `front/src/routes/integration/all/tuya/discover-page/DiscoverTab.jsx`, `front/src/routes/integration/all/tuya/discover-page/style.css`, `front/src/routes/integration/all/tuya/setup-page/SetupTab.jsx`, `front/src/routes/integration/all/tuya/style.css`	Reworks Tuya device editor and setup flows: IP masking, local/cloud toggle, protocol selection, local poll and local-scan UI, websocket-driven status, GitHub-issue flows, device ranking/sorting, and related UX changes.
Front — i18n `front/src/config/i18n/de.json`, `front/src/config/i18n/en.json`, `front/src/config/i18n/fr.json`	Adds extensive Tuya translations for device metadata, local/cloud polling UI, GitHub issue helpers, and new AC feature labels (fan-speed, eco, drying, cleaning, aux-heat, light, sleep, health).
Server — API & controller `server/services/tuya/api/tuya.controller.js`	Adds controller endpoints: POST /local-poll, POST /local-scan, GET /status, POST /disconnect wired to Tuya manager methods.
Server — Tuya core & lifecycle `server/services/tuya/index.js`, `server/services/tuya/lib/index.js`, `server/services/tuya/lib/tuya.init.js`, `server/services/tuya/lib/tuya.connect.js`, `server/services/tuya/lib/tuya.disconnect.js`, `server/services/tuya/lib/tuya.getStatus.js`, `server/services/tuya/lib/tuya.saveConfiguration.js`	Implements auto-reconnect (quick-reconnect scheduling), manual disconnect, config-hash checks, exposes localScan/localPoll/getStatus/manualDisconnect, updates status/error emission and connection error mapping.
Server — Local scan & poll `server/services/tuya/lib/tuya.localScan.js`, `server/services/tuya/lib/tuya.localPoll.js`, `server/services/tuya/lib/tuya.localMapping.js`, `server/services/tuya/lib/tuya.poll.js`, `server/services/tuya/lib/tuya.setValue.js`	Adds UDP local discovery, protocol-aware local DPS polling (tuyapi / tuyapi-newgen), DPS parsing, local write path with cloud fallback, and integration into polling/state emission.
Server — Mappings & conversion `server/services/tuya/lib/mappings/index.js`, `server/services/tuya/lib/mappings/cloud/.js`, `server/services/tuya/lib/mappings/local/.js`, `server/services/tuya/lib/device/tuya.deviceMapping.js`, `server/services/tuya/lib/device/tuya.convertDevice.js`, `server/services/tuya/lib/device/tuya.convertFeature.js`, `server/services/tuya/lib/device/tuya.loadDeviceDetails.js`, `server/services/tuya/lib/device/tuya.loadDevices.js`	Introduces device-type-aware cloud/local mappings (air-conditioner, smart-socket), bidirectional mode/fan mappings, scaling/unit conversions, richer convertDevice output (params, properties, thing_model), parallel detail loading, and pagination changes.
Server — Utilities & constants `server/services/tuya/lib/utils/*.js`, `server/utils/constants.js`	Adds DEVICE_PARAM_NAME constants, config-hash builder, normalize helpers, device-params utilities, new AC_FAN_SPEED enum and extended DEVICE_FEATURE_TYPES, and new GLADYS_VARIABLES entries.
Server — Tests & fixtures `server/test/services/tuya/**`, `server/test/lib/device/temperature-sensor/temperature-sensor.test.js`, `server/test/services/tuya/example/air-conditioner.json`, `server/test/services/tuya/tuya.mock.test.js`	Large expansion of tests covering local scan/poll, convert/load/mapping logic, auto-reconnect, manual disconnect, controller endpoints, device-param utilities, and a new air-conditioner fixture; adds temperature-range tests.
Packages `server/services/tuya/package.json`, `server/package.json`	Adds tuyapi and `@demirdeniz/tuyapi-newgen` dependencies for local protocol support; bumps duckdb from ^1.4.3 to ^1.4.4.
Device temperature validation `server/lib/device/temperature-sensor/temperature-sensor.getTemperatureInRoom.js`	Filters out-of-range temperature readings (Celsius and Fahrenheit) from averaging to exclude implausible values.

Sequence Diagram(s)

sequenceDiagram
  participant UI as Client UI
  participant API as Gladys API
  participant Manager as TuyaHandler
  participant Device as Local Tuya Device
  participant GitHub as GitHub

  UI->>API: POST /api/v1/service/tuya/local-scan
  API->>Manager: localScan()
  Manager->>Device: open UDP sockets, listen
  Device-->>Manager: UDP broadcast (device info)
  Manager->>Manager: buildLocalScanResponse (merge with discoveredDevices)
  Manager-->>API: scan response
  API-->>UI: scan response

  UI->>API: POST /api/v1/service/tuya/local-poll {deviceId}
  API->>Manager: localPoll(payload)
  Manager->>Device: connect (tuyapi / newgen) and request DPS
  Device-->>Manager: DPS payload
  Manager->>Manager: updateDiscoveredDeviceAfterLocalPoll()
  Manager-->>API: poll result
  API-->>UI: poll result

  UI->>API: Create GitHub issue (partial support)
  API->>Manager: build/create issue payload
  Manager->>GitHub: query/create issue
  GitHub-->>Manager: issue result
  Manager-->>API: issue status
  API-->>UI: issue status

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~70 minutes

Possibly related issues

Tuya (local) []: Add support for Air Conditioner #2457 — Adds air-conditioner local support and DP mappings; this PR implements air-conditioning mappings, local poll/scan and related UI that address that objective.

Possibly related PRs

Update duckdb to 1.4.4 #2456 — Matches the duckdb dependency bump also present in this PR.

Suggested reviewers

Pierre-Gilles

Poem

"🐰 Hoppity, I sniff the air tonight,
Local scans hum, fan-speeds take flight,
Modes and DPS all neatly unfurled,
Auto-reconnect keeps devices in the world,
A tiny rabbit cheers — Tuya made bright!"

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

relativeci · 2026-02-23T02:05:16Z

#3981 Bundle Size — 11.53MiB (+1.18%).

a3ae938(current) vs 8db6b0d master#3902(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics

5 changes

2 regressions

	Current #3981	Baseline #3902
Initial JS	`6.51MiB`(`+2.03%`)	`6.38MiB`
Initial CSS	`310.24KiB`(`+0.02%`)	`310.18KiB`
Cache Invalidation	`67.47%`	`0%`
Chunks	`51`	`51`
Assets	`179`	`179`
Modules	`1648`(`+0.3%`)	`1643`
Duplicate Modules	`21`	`21`
Duplicate Code	`0.93%`(`-1.06%`)	`0.94%`
Packages	`136`	`136`
Duplicate Packages	`2`	`2`

Bundle size by type

2 changes

2 regressions

	Current #3981	Baseline #3902
JS	`8.42MiB` (`+1.62%`)	`8.28MiB`
IMG	`2.66MiB`	`2.66MiB`
CSS	`328.09KiB` (`+0.02%`)	`328.03KiB`
Fonts	`93.55KiB`	`93.55KiB`
Other	`18.82KiB`	`18.82KiB`
HTML	`13.58KiB`	`13.58KiB`

Bundle analysis report Branch Terdious:tuya-air-conditioner-su... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

Terdious and others added 28 commits February 11, 2026 15:58

add cloud discovery metadata

11cb7ed

add local discovery metadata

db22529

Corrige les URL de l'API locale et du WebSocket pour utiliser localhost

ff5d001

refactor: remove air conditioning model and related mappings; simplif…

d9598ca

…y device conversion logic

feat: add local polling and scanning tests for TuyaHandler

3612b9c

refactor: simplifier la logique de poll local et améliorer la lisibil…

7ea3468

…ité du code

refactor: améliorer la logique de chargement des appareils Tuya et me…

e2d7189

…ttre à jour les tests associés

fix: corriger la logique de pagination dans loadDevices et ajouter un…

5f2d2a5

… champ d'erreur dans le payload de l'événement WebSocket

refactor: améliorer la logique de mise à jour des appareils découvert…

ebd3dc3

…s et ajouter des tests pour la gestion des appareils locaux

feat: ajouter des descriptions et des limitations pour la configurati…

a3f8359

…on Tuya dans les fichiers de langue

feat: ajouter les champs Product ID et Product Key dans la configurat…

50e1122

…ion Tuya et mettre à jour les traductions

refactor: améliorer la journalisation dans le processus de scan local…

513e2d0

… des appareils Tuya

logger

389d231

refactor: améliorer la gestion des erreurs du socket UDP dans le scan…

36dfd91

… local

refactor: mettre à jour la méthode de liaison des sockets pour permet…

b8e1a9f

…tre l'utilisation d'adresses spécifiques

feat: améliorer le scan local des appareils Tuya avec gestion des err…

8d2536f

…eurs de port et mise à jour des traductions

feat: mettre à jour les descriptions de configuration Tuya pour inclu…

a0243b6

…re des liens vers la documentation et les options de connexion

feat: ajouter des messages d'information sur le protocole 3.5 et la c…

70c7d4a

…réation de rapports GitHub pour les appareils Tuya

Merge branch 'master' into tuya-local-baseline

8082994

feat(tuya): améliorer les tests pour la gestion des connexions et des…

588225e

… erreurs de port

Merge branch 'master' into tuya-local-baseline

924e098

feat(tuya): améliorer la gestion des informations locales des apparei…

b6cb28b

…ls et des tests associés

feat(tuya): traduire les clés de produit et améliorer les messages de…

52a54b2

… débogage pour la gestion des appareils

feat(tuya): améliorer la gestion des erreurs et des messages de débog…

ae8a1d6

…age, ajouter des tests pour la reconnexion automatique et la découverte des appareils

feat(tuya): nettoyer les messages de débogage et améliorer la gestion…

c68075d

… des paramètres dans le code de configuration Tuya

Terdious added 27 commits March 1, 2026 13:51

fix(tuya): improve setup alerts and baseline test isolation

c55a6e1

fix(tuya): sanitize local timeouts and persist local-only devices

74138b5

fix(tuya): harden mapping normalization and poll fallback

47130ac

fix(tuya): harden fixture tests and device diagnostics

ae8b01b

style(tuya): apply frontend formatting on device box

b88e723

fix(tuya): open github issue popup before async check

dc58f5c

fix(tuya): harden setup status and local scan follow-up

fd11ac1

fix(tuya): apply follow-up hardening adjustments

d4479c5

feat(tuya): improve unsupported device issue reports

fa06ada

fix(tuya): refine unsupported cloud code detection

33d861e

refactor(tuya): align frontend boolean helper imports

b226e5d

docs(tuya): clarify unsupported device onboarding guidance

754dd35

test(tuya): align smart meter fixtures with issue captures

85f643c

docs(tuya): improve unsupported device guidance

359fdd7

Add support for LSC Power Plug FR smart socket

124b341

Fix Tuya loadDeviceDetails null-report test

b2cc02d

Refine Tuya smart socket ignored mappings

b483099

test(tuya): harden local scan and cloud loading cases

3171274

feat(tuya): support cloud shadow reads for thing-model devices

2ca5a62

feat(tuya): add support for pilot thermostat devices

2b359f1

test(tuya): align LSC smart socket fixture cloud strategy

b6ce656

test(tuya): restore unified cloud strategy fixture on thermostat branch

bd0d9ba

fix(tuya): handle unreachable local devices cleanly

340353a

test(tuya): improve thermostat branch coverage

df476d3

refactor(tuya): simplify poll temperature guards

33241a1

refactor(tuya): remove dead defensive guards

034de26

feat(tuya): add air-conditioner mappings and controls

a66f773

Terdious force-pushed the tuya-air-conditioner-support branch from ed38a86 to a66f773 Compare March 5, 2026 07:12

Terdious changed the title ~~Tuya Air Condioner support~~ Tuya - Air Condioner support - PR9 Mar 5, 2026

chore(tuya): clarify cloud setValue logs

a3ae938

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tuya - Air Condioner support - PR9#2458

Tuya - Air Condioner support - PR9#2458
Terdious wants to merge 96 commits intoGladysAssistant:masterfrom
Terdious:tuya-air-conditioner-support

Terdious commented Feb 23, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 23, 2026 •

edited

Loading

Reviews paused

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related issues

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

relativeci bot commented Feb 23, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Terdious commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request check-list

Description of change

Summary

Details

Why this matters

Scope

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related issues

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

relativeci bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

#3981 Bundle Size — 11.53MiB (+1.18%).

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Terdious commented Feb 23, 2026 •

edited

Loading

coderabbitai bot commented Feb 23, 2026 •

edited

Loading

relativeci bot commented Feb 23, 2026 •

edited

Loading